Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(button): use content property and move to manager #978

Merged
merged 15 commits into from
Apr 1, 2023
Merged

feat(button): use content property and move to manager #978

merged 15 commits into from
Apr 1, 2023

Conversation

njfamirm
Copy link
Member

No description provided.

@njfamirm njfamirm added this to the v0.x milestone Mar 24, 2023
@njfamirm njfamirm self-assigned this Mar 24, 2023
@njfamirm njfamirm requested a review from alimd as a code owner March 24, 2023 11:19
@njfamirm njfamirm changed the base branch from next to feat/com-order-detail March 24, 2023 11:20
@njfamirm njfamirm added enhancement Enhancement of the code, not introducing new features. performance Improving performance of the project, not introducing new features. labels Mar 24, 2023
@njfamirm njfamirm force-pushed the feat/button-content branch from b3b0b2d to d3e3796 Compare March 27, 2023 16:19
@alimd alimd force-pushed the feat/com-order-detail branch from ffbcf19 to 073b913 Compare March 31, 2023 01:28
Base automatically changed from feat/com-order-detail to next March 31, 2023 01:34
@alimd alimd force-pushed the feat/button-content branch from d7f6ea1 to 992cc8a Compare March 31, 2023 01:36
@alimd
Copy link
Member

alimd commented Mar 31, 2023

نفهمیدم چی شد! الان بخوایم متن ساده و مستقیم به کلید بدیم باید چیکار کنیم؟

@njfamirm njfamirm force-pushed the feat/button-content branch from 94c1919 to 1db4f71 Compare March 31, 2023 12:06
@njfamirm njfamirm requested a review from alimd March 31, 2023 12:08
@njfamirm
Copy link
Member Author

use content property for button and move to manager

njfamirm and others added 15 commits April 1, 2023 15:20
@njfamirm @alimd
refactor(ui-kit/button): use button content property
ae56e93
@njfamirm @alimd
feat: use button content
a3f3872
@alimd
refactor(ui/button): render template and reflect attribs
1ed534b
@njfamirm @alimd
refactor(ui-kit/button): check click signal id on click handler
dc1abcc
@njfamirm @alimd
refactor(ui-kit/icon-button): render template and reflect attributes
24bbcd7
@njfamirm @alimd
refactor(com-pwa/order-detail): move button to manager
bff107d
@njfamirm @alimd
refactor(com-pwa/new-ordr): move button to manager
24d6467
@njfamirm @alimd
fix(com-pwa/buttons): detail label key
8213869
@njfamirm @alimd
fix(com-pwa): reload button
dc3fda0
@njfamirm @alimd
refactor(com-pwa/new-order): set label Key on button content
ea11f80
@njfamirm @alimd
fix(ui/icon-button): default content value
4303620
@njfamirm @alimd
feat(com-pwa/buttons): print button
6237fc5
@njfamirm @alimd
feat(com-pwa/order): use print button in order detail top-app-bar
9ea55f6
@njfamirm @alimd
feat(ui/button): label on content
df010a8
@njfamirm @alimd
fix(ui/snackbar): use label for action button content
68beefa
@alimd alimd force-pushed the feat/button-content branch from 1db4f71 to 68beefa Compare April 1, 2023 11:50
@alimd alimd merged commit 652e6b8 into next Apr 1, 2023
@alimd alimd deleted the feat/button-content branch April 1, 2023 11:50
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alimd alimd Awaiting requested review from alimd alimd is a code owner

Assignees

@njfamirm njfamirm

Labels
enhancement Enhancement of the code, not introducing new features. performance Improving performance of the project, not introducing new features.
Projects
None yet
Milestone
v0.x
Development

Successfully merging this pull request may close these issues.
2 participants
@njfamirm @alimd